Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilising test_squ #9083

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Stabilising test_squ #9083

merged 3 commits into from
Nov 10, 2022

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Nov 6, 2022

Coveralls had been complaining about /qiskit/extensions/quantum_initializer/squ.py unstable coverage. For example:
Screenshot 2022-11-06 at 14 10 35

There was a missing seeding in a test. I also moved it to ddt.

@1ucian0 1ucian0 requested a review from a team as a code owner November 6, 2022 13:15
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3404493696

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 84.539%

Totals Coverage Status
Change from base Build 3393994050: 0.003%
Covered Lines: 62453
Relevant Lines: 73875

💛 - Coveralls

@1ucian0 1ucian0 added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Nov 7, 2022
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comma is actually fine, and (at least in the UK, I believe) it's more common to introduce non-defining clauses (using "which" rather than "that") with a comma. It doesn't matter, though.

@jakelishman jakelishman added stable backport potential The bug might be minimal and/or import enough to be port to stable automerge labels Nov 10, 2022
@mergify mergify bot merged commit b224a2e into Qiskit:main Nov 10, 2022
mergify bot pushed a commit that referenced this pull request Nov 10, 2022
* stabilized squ tests

* seeding rng

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit b224a2e)
mergify bot added a commit that referenced this pull request Nov 15, 2022
* stabilized squ tests

* seeding rng

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit b224a2e)

Co-authored-by: Luciano Bello <[email protected]>
Cryoris pushed a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
* stabilized squ tests

* seeding rng

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants